search

capitalone / Particle-Cloud-Framework

https://capitalone.github.io/Particle-Cloud-Framework/docs/build/html/index.html
Apache License 2.0
36 stars 28 forks source link

Elasticsearch Particle #135

Closed Bryantle1028 closed 5 years ago

Bryantle1028 commented 5 years ago

Implemented elasticsearch particle with tests in testdata.json and example_es_domain.py

davidyum commented 5 years ago

I think you have a bunch of palcebo json files (96 for describe) from running record test multiple times. Could you just include one of each.

brianhlee commented 5 years ago

You have to delete all the useless describes that were returned while the particle was still spinning up. Remember I mentioned that you can just delete them and renumber the ones left over so that it skips over the 10 min spin up time.

David mentioned that there might be an option for placebo to skip the empty responses. Might be worth looking into that if you don't want to do it manually.

Bryantle1028 commented 5 years ago

I think you have a bunch of palcebo json files (96 for describe) from running record test multiple times. Could you just include one of each.

Bryantle1028 commented 5 years ago

I think you have a bunch of palcebo json files (96 for describe) from running record test multiple times. Could you just include one of each.

Should I just include one of each call even if some are not empty?

brianhlee commented 5 years ago

Just delete everything in the folder and run generate once. Then go through and find the chunk of empty describe calls that are made while the particle is spinning up. This will make the test run faster without waiting the 10 mins it takes to spin it up.