search

capitalone / datacompy

Pandas, Polars, and Spark DataFrame comparison for humans and more!
https://capitalone.github.io/datacompy/
Apache License 2.0
420 stars 124 forks source link

Fix suffix on all mismatches reports #291

Closed enzorooo closed 2 months ago

enzorooo commented 2 months ago

Hi datacompy team!

I noticed that when using datacompy.Compare(...).all_mismatches() it defaults to using the "_df1" "_df2" strings. Which shouldn't be the case when users have predefined this upon declaring the comparison settings.

I fixed it in this contribution. Let me know if it works for you.

Thanks!

enzorooo commented 2 months ago

I see that some tests have failed. Though, I'm not exactly sure why that is given the revision is small. If you can provide some guidance for me to fix it, I'd be glad to do it on my end.

Thanks!

fdosani commented 2 months ago

@enzorooo First off thank you for the PR. Greatly appreciated. I think it is failing cause the test check the formatting of the output which will not match due to the change. Give me a bit here, I'll swing back to this and take a closer look.

fdosani commented 2 months ago

Closing in favour of #293