search

capitalone / react-native-pathjs-charts

Android and iOS charts based on react-native-svg and paths-js
Apache License 2.0
879 stars 261 forks source link

pallete prop is misspelled #175

Open tuantle opened 7 years ago

tuantle commented 7 years ago

Please rename to palette.

marzolfb commented 7 years ago

Agreed this is a bug. Just for historical context, this library is based off of https://github.com/rsamec/react-pathjs-chart and that seems to be where the misspelling originated.

While introducing a new property with the correct spelling is straightforward and non-controversial, removing the old misspelled version of the property is arguable as doing so would be introducing a breaking change. It would be interesting to hear from others on whether a breaking change like that would be appropriate.