search

capitalone / react-native-pathjs-charts

Android and iOS charts based on react-native-svg and paths-js
Apache License 2.0
879 stars 260 forks source link

feature: add interaction on line chart. #221

Closed soloviola closed 6 years ago

soloviola commented 6 years ago

React-native-pathjs-charts team:

Hey, I was using your chart library for a while. Really handy stock charts to use and I love it.

I worked on chart interaction and tried to implement gesture on line to meet my own project requirement. And I just cleaned it up a little bit and want to share my stuff. This commit add a property interaction which default to false. When turn to true. It will response with gesture.

We can specify call back function in panHandlerStart, panHandlerMove, panHandlerEnd. Each for different stage of gesture.

It also have another feature called cursorLine default as red color with width = 1, which will show as a vertical line on top of the chart as a cursor to indicate while the finger is pressing.

Let me know what you think.

Thank you for contributing a pull request.

Please ensure that you have signed the CLA.

soloviola commented 6 years ago

Comments applied. Example added to the example app as Stockline chart - graphic.

pasted graphic

marzolfb commented 6 years ago

Thanks for the contribution!