capitec / omni-components

Modern UI component library for mobile and web.
https://capitec.github.io/open-source/docs/omni-components/
MIT License
23 stars 8 forks source link

Bug: Date picker mobile rendering inefficiency #209

Closed chromaticWaster closed 12 months ago

chromaticWaster commented 1 year ago

Description:

closes #207

Update to lit v2.8.0 included

The Date picker component requires a performance improvement in mobile rendering cases. Currently when the Date picker calendar is toggled it is rendered in a dialog element.

In some cases users will have multiple Date pickers for range scenarios this will result in a dialog being added to the DOM along with a nested Omni-Calendar component.

To provide rendering efficiency the Omni-calendar is only nested in the dialog element when the Date picker is toggled. This results in better load times for views on mobile devices.

Once this change is in a investigation will be required to improve the rendering performance of the omni-calendar.

Screenshots (if appropriate):

No requirement for visual screenshot comparison as nothing changed beyond the criteria in the template function.

Date picker test results

image

All Submissions:

Changes to Core Features: