capitec / omni-components

Modern UI component library for mobile and web.
https://capitec.github.io/open-source/docs/omni-components/
MIT License
23 stars 8 forks source link

Add css variables to components #241

Closed chromaticWaster closed 1 month ago

chromaticWaster commented 2 months ago

Description:

(Link to bug/feature from Issues and how you resolve it)

Add css variable to give user of the following omni input components the ability to style the auto select hover color of the internal input element

omni-email-field omni-number-field omni-pin-field omni-search-field omni-text-field

Expose a new css variable on the Modal component to give users the ability to apply a min width to the component

Added blur on enter for Search field component

Testing was done via a alpha

All Submissions:

Changes to Core Features:

chromaticWaster commented 1 month ago

Note there is currently a issue on the docs site where the Icon component stories do not render as expected hence those specific tests failing the following ticket has been logged as a issue to address this.

https://github.com/capitec/omni-components/issues/243

In the case of the Select component a issue should be logged for that this results in screenshot comparisons being inconsistent and usually results in the tests for this component failing.

https://github.com/capitec/omni-components/issues/219

chromaticWaster commented 1 month ago

Merging this the current screenshot comparison for some of the input fields are out by 1 pixel. Cases for failures for Icon and Select component is logged as an issue that needs to be addressed in future