search

capless / warrant

Python library for using AWS Cognito. With support for SRP.
Apache License 2.0
468 stars 192 forks source link

Added Support for non en_US locale #103

Closed limlug closed 6 years ago

limlug commented 6 years ago

If the underlying OS has it's locale set to something different than en_* then the authentication code may break because AWS is expecting the day of week in english.

I found this issue while integrating warrant with a pyQT based application on a system with de_DE locale. The day of week was transmitted as Do instead Thu and caused the exception: InvalidParameterException: TIMESTAMP format should be EEE MMM d HH:mm:ss z yyyy in english.

This modification would introduce babel.dates as additional dependency.

bjinwright commented 6 years ago

@limlug Thank you for this pull request but this should be moved to warrant-lite