invalid strftime in aws_srp.py

[stephenoneal]

https://github.com/capless/warrant/blob/master/warrant/aws_srp.py#L158

I think you want "%a %b %d %H:%M:%S UTC %Y" for the strftime %-d is invalid.

[bjinwright]

I believe you are correct.

[armicron]

It will not authenticate with %d, as it will have a leading zero. @stephenoneal what python version and OS do you use?

http://stackoverflow.com/questions/904928/python-strftime-date-without-leading-0

[stephenoneal]

python 3.4, Windows

[stephenoneal]

oddly i changed it to datetime.datetime.utcnow().strftime("%a %b %d %H:%M:%S UTC %Y") locally and it's passing the PASSWORD_VERIFIER challenge

[armicron]

oddly i changed it to datetime.datetime.utcnow().strftime("%a %b %d %H:%M:%S UTC %Y") locally and it's passing the PASSWORD_VERIFIER challenge

It will fail on May 1.

p.s. To fix this issue the code should be compatible with Windows and Linux both.

[bjinwright]

Oh yeah, that happened at the beginning of this month.

[stephenoneal]

my attention on this is not great right now. need more coffee..

import platform windows_os = any(platform.win32_ver())

    timestamp = test_timestamp or \
                ( datetime.datetime.utcnow().strftime("%a %b %#d %H:%M:%S UTC %Y") if windows_os \
                else datetime.datetime.utcnow().strftime("%a %b %-d %H:%M:%S UTC %Y") )

[bjinwright]

@armicron I think @stephenoneal is proposing a way to detect the OS and format the string accordingly.

[armicron]

I can't test it on windows.

import sys

if sys.platform.startswith('win32'):
    format_string = "%a %b %#d %H:%M:%S UTC %Y"
else:
    format_string = "%a %b %-d %H:%M:%S UTC %Y"

timestamp = test_timestamp or datetime.datetime.utcnow().strftime(format_string)

[bjinwright]

Fixed in #28