search

capless / warrant

Python library for using AWS Cognito. With support for SRP.
Apache License 2.0
468 stars 192 forks source link

python-jose not compatible with python 3.6 #31

Closed nueverest closed 6 years ago

nueverest commented 7 years ago

python-jose depends on pycrypto which is no longer maintained (3-4 years old). This breaks compatibility with python 3.6 and people developing on windows machines.

See issue here: https://github.com/mpdavis/python-jose/issues/41

pycryptodome is the preferred solution https://github.com/Legrandin/pycryptodome

This is making it hard for me to use your cool library.

It appears that check_token() and verify_token() depend on jose, and it is not immediately obvious how I can work around this.

armicron commented 6 years ago

Can we use python-jose fork, until it will be fixed in the original repository?

bjinwright commented 6 years ago

Can we create a fork of the fork, rename it and push it to PyPi? If we try to add it to requirements.txt pointed to the git repo people that don't have git installed will not be able to install it. @nueverest Do you have a problem with that plan?

armicron commented 6 years ago

What is a name for the new package?

bjinwright commented 6 years ago

python-jose-cryptodome

armicron commented 6 years ago

https://github.com/capless/python-jose-cryptodome/pull/1