search

capless / warrant

Python library for using AWS Cognito. With support for SRP.
Apache License 2.0
468 stars 192 forks source link

Detect glibc system and use the correct timeformat #79

Closed pvizeli closed 6 years ago

pvizeli commented 6 years ago

A other fix for https://github.com/capless/warrant/pull/75 that work on all platforms (https://github.com/capless/warrant/issues/55)

pvizeli commented 6 years ago

Any comments on that or other task to do for me?

armicron commented 6 years ago

I suggest removing test_timestamp argument from the process_challenge method because it's not used now. Also, it would be better if PR will contain only 1 commit.

Code will look like this

        # re strips leading zero from a day number (required by AWS Cognito)
        timestamp = re.sub(r" 0(\d) ", r" \1 ",
                           datetime.datetime.utcnow().strftime("%a %b %d %H:%M:%S UTC %Y"))

p.s. Don't forget to remove unused imports. I can do it by myself if you don't have time just let me know.

pvizeli commented 6 years ago

@armicron thanks for your review. I address the comments above

armicron commented 6 years ago

I approve, but I don't have write access, so I can't merge.

balloob commented 6 years ago

@armicron you do have write access according to GitHub.

image

I would love to see this fix released as a new version of Warrant soon if possible 👍

armicron commented 6 years ago

This is what I see: "You're not authorized to merge this pull request", "Only those with write access to this repository can merge pull requests."

pvizeli commented 6 years ago

@bjinwright Is it possible to become a bugfix release that we can use it on our next release?

bjinwright commented 6 years ago

Done the new version 0.6.1 should have these changes