search

capnkirok / Inventory-Pets

11 stars 0 forks source link

Storing null in NBTTagCompounds #65

Closed bloodmc closed 8 years ago

bloodmc commented 8 years ago

http://pastebin.com/qjxxeViN

null should never be stored in NBT

Currently using MC1.8.9 1.4.0 version

capnkirok commented 8 years ago

Will take a look. Storing null is weird. Storing null onto the sponge is very weird.

Edit: Realized last week that 'Sponge' refers to SpongeForge and not the pet Sponge.

bloodmc commented 8 years ago

@capnkirok thanks!. We purposely crash the game and log a stacktrace to avoid bad data being stored in NBT.

As seen here

https://github.com/SpongePowered/SpongeForge/blob/master/src/main/java/org/spongepowered/mod/mixin/core/nbt/MixinNBTTagCompound.java#L43

bloodmc commented 8 years ago

@capnkirok any luck with fixing this?

capnkirok commented 8 years ago

Ok, think I figured this one out. Was a typo in the Extended Properties setter. Issuing a fix shortly. Thanks for reporting!

capnkirok commented 8 years ago

Ok, this is updated in 1.4.4, now on Curse

capnkirok commented 8 years ago

Reopening. Still seeing issues with SpongeForge. Typo didn't change anything.

capnkirok commented 8 years ago

BloodMC, if you are still there, try this version. I've just made an additional null check. Very curious to hear the result: https://www.dropbox.com/s/aiv70vq9ng57h91/inventorypets-1.8.9-1.4.4.jar?dl=0

capnkirok commented 8 years ago

Closing this on our side. Have confirmed that my additional check fixes the issue. Solved in 1.4.5

capnkirok commented 8 years ago

http://minecraft.curseforge.com/projects/inventory-pets/files/2297618