search

capnmidnight / Calla

Virtual Meetups through Jitsi
https://www.calla.chat
MIT License
1.08k stars 77 forks source link

Use logarithmic volume scaling #23

Closed capnmidnight closed 4 years ago

capnmidnight commented 4 years ago

HTML5 audio volume setting seems to provide for a linear response. I couldn't tell at first, but after testing for a while, it seems pretty clear, given there is very little volume drop off until you reach the edge of the hearing range.

capnmidnight commented 4 years ago

I think this can be done by just calling Math.sqrt() on the final volume value calculated in user.js/readUser

capnmidnight commented 4 years ago

I pushed out the change, but we'll have to test it live to see if it's any good.

hilarysk commented 4 years ago

Hello! A friend sent me this and I've been playing around. Not sure if these changes are live yet, but the issue still appears to be happening, fwiw.

capnmidnight commented 4 years ago

Yeah, the previous change I made just made the problem worse. That's what I get for trying to visual curves in my head.

I pushed out another tweak this morning and was able to test it a little bit ago. It seems better. Let me know what you think.

hilarysk commented 4 years ago

Just tested it, and it seems much better ❤️ Nice work!