search

capnmidnight / Primrose

A syntax-highlighting text editors that renders to an HTML5 Canvas
https://www.primrosevr.com
Other
530 stars 67 forks source link

Fix for issue #122 #129

Closed upodroid closed 7 years ago

upodroid commented 7 years ago

Bug fix

Sorry for the duplicate PR, I was unable to modify the previous PR.

capnmidnight commented 7 years ago

Hi there! I'll be writing a "getting started" document very soon that will cover how to be able to make changes on Primrose and then test those changes. I'm sorry, I didn't expect people to come on to the project so soon after I made the announcement on Twitter, so I'm not really fully prepared with documentation yet.

With the project set up completely so you can run the code after making edits to it, you'll be able to see when changes you make don't have the desired effect. In this particular case, the desired effect is "nothing changes about how the apps run." This is just a cleanup task, what is referred to as "refactoring". Refactoring is kind of like sidestepping. It's something we do that doesn't change how the program works but hopefully makes future changes easier.

In this case, a line got deleted that now makes the script not work.

But that's ok. That's why we're here. The point is not that I can do the change on my own. The point is that the change is an opportunity for you to practice and learn.

I'll get the "Getting Started" document written tomorrow. We can then get you set up so you can run the project directly and see the result of your changes. Then, we can discuss what deleting that particular line of code did, and how to tell it should have stayed.

capnmidnight commented 7 years ago

Sorry for the delay. I didn't realize how unprepared I was to handle new people coming on board. Thank you for your patience.

For being able to test the project, you should be able to follow these instructions.

I can see from the code that everything is right now, so I can just merge this in now.