search

capnmidnight / Primrose

A syntax-highlighting text editors that renders to an HTML5 Canvas
https://www.primrosevr.com
Other
530 stars 73 forks source link

Sundial demo should have the sun disk face the user's head, not the sky's center position #130

Closed capnmidnight closed 7 years ago

capnmidnight commented 7 years ago

The sky's center position is located at the user's feet, so in some scenarios where the user has moved a lot, the sun will start to look like an oval, and then eventually disappear.

To fix this issue, this line of code needs to be changed from sun.lookAt(env.sky.position); to sun.lookAt(env.input.head);.

KehindeAyanleye commented 7 years ago

Hi Sean,

I'm trying to pick up on this as a first timer. The link this line of code throws a 404 error page. Where can I find this code please? I'm currently setting up the project and waiting for npm install to complete.

PS: Sorry about the sickness. Great to know you've all bounced back now.

capnmidnight commented 7 years ago

Hi Kehinde, thanks!

Yes, you're right. With issue #135, all of the demos moved from the doc/ directory to a new demos/ directory, but I forgot to update any open issues that referenced the demos.

I updated the link in the original issue description. It should go to the right page now.

KehindeAyanleye commented 7 years ago

Thanks Sean, It works now. I'll be happy to take this! Thank you.

KehindeAyanleye commented 7 years ago

I have an issue at the moment.

Gulp hangs after Finished 'default' after while running gulp.

[03:20:04] Using gulpfile ~/Documents/wowCodes/Primrose/gulpfile.js [03:20:04] Starting 'PrimroseWithDoc:umd:js:beautify'... [03:20:04] Starting 'preloader:js:beautify'... [03:20:04] Starting 'preloader:js:debug'... [03:20:04] Starting 'Primrose:html:debug'... [03:20:04] Starting 'Primrose:css:build:debug'... Writing preloader.js [03:20:05] Finished 'preloader:js:debug' after 686 ms [03:20:05] Starting 'watch:preloader:js:debug:only'... preloader:js:debug:only watching [ '/Users/k/Documents/wowCodes/Primrose/preloader//' ] [03:20:05] Finished 'watch:preloader:js:debug:only' after 14 ms [03:20:05] Finished 'preloader:js:beautify' after 1.06 s [03:20:06] Finished 'Primrose:css:build:debug' after 1.61 s [03:20:06] Starting 'watch:Primrose:css:build:debug'... Primrose:css:build:debug watching [ '.styl', 'doc//.styl' ] [03:20:06] Finished 'watch:Primrose:css:build:debug' after 17 ms [03:20:06] Starting 'css'... [03:20:06] Finished 'css' after 2.24 μs [03:20:08] Finished 'Primrose:html:debug' after 3.97 s [03:20:08] Starting 'watch:Primrose:html:debug'... Primrose:html:debug watching [ '.pug', 'doc//*.pug', 'templates/*/.pug' ] [03:20:08] Finished 'watch:Primrose:html:debug' after 58 ms [03:20:08] Starting 'html'... [03:20:08] Finished 'html' after 4.49 μs [03:20:08] Finished 'PrimroseWithDoc:umd:js:beautify' after 4.2 s [03:20:08] Starting 'format'... [03:20:08] Finished 'format' after 2.57 μs [03:20:08] Starting 'PrimroseWithDoc:umd:js:debug'... Writing PrimroseWithDoc.js [03:20:18] Finished 'PrimroseWithDoc:umd:js:debug' after 10 s [03:20:18] Starting 'PrimroseWithDoc:umd:js:post:debug'... [03:20:18] Finished 'PrimroseWithDoc:umd:js:post:debug' after 42 ms [03:20:18] Starting 'watch:PrimroseWithDoc:umd:js:post:debug'... PrimroseWithDoc:umd:js:post:debug watching [ '/Users/k/Documents/wowCodes/Primrose/src//*' ] [03:20:18] Finished 'watch:PrimroseWithDoc:umd:js:post:debug' after 82 ms [03:20:18] Starting 'js'... [03:20:18] Finished 'js' after 3.32 μs [03:20:18] Starting 'default'... [03:20:18] Finished 'default' after 2.32 μs

capnmidnight commented 7 years ago

No, that's what it's supposed to do. It will wait for you to make a change to a file, then it will automatically re-run the tasks for processing the file you changed.

KehindeAyanleye commented 7 years ago

What I noticed was this.

At first, I cloned directly without forking. When I ran gulp It starting serving from port 80 and the browser opened. But of course I couldn't pull a request.

So I reverted to forking it and cloning from my repo, but this time, it hung while running gulp; and after making a change to the file it didn't / I didn't see it re-run the task neither was it serving on port 80. Am I doing anything wrong?

KehindeAyanleye commented 7 years ago

Okay, I think I got it now. Reading issue #149 answered my questions. You were right.

capnmidnight commented 7 years ago

Also, it looks like your fork is several commits behind from the main repository. When I view your fork in your profile, it says you're 2 commits ahead, 54 behind my version. Perhaps you made the fork a while ago? I notice, for example, that your version of the repository doesn't have the demos/ directory.

I'm not sure what the best way is to handle a pull request from a fork from an older version like this. I think with the way things have overlapped, specifically with the big change of moving the demos to their own directory, the easiest thing would be for you to delete your repository, re-fork from mine again, and then make the change again. That's kind of a pain in the butt, though I think it would be less of a pain than trying to figure out how to work the merge out.

KehindeAyanleye commented 7 years ago

Let's do it! No worries.

KehindeAyanleye commented 7 years ago

Pull request issued. I'm hopeful this should be fine. Thank you.