capnproto / capnpc-rust

Cap'n Proto code generation for Rust
76 stars 26 forks source link

Use AsRef in the compile function #17

Closed aochagavia closed 9 years ago

aochagavia commented 9 years ago

I think this is more ergonomic to use, and the change doesn't break existing code. It does, however, add a little bit of complexity (maybe not all rustaceans are aware of what the AsRef trait does, yet). What do you think?

dwrensha commented 9 years ago

I think AsRef<Path> is the way to go, especially since it is so heavily used in the standard path API. Thanks!