search

capnproto / capnproto-dlang

Cap'n Proto in pure D
Other
19 stars 6 forks source link

Correct Dlang keywords. #6

Closed kookman closed 7 years ago

ThomasBrixLarsen commented 7 years ago

Thanks. I don't think that dstring/string/wstring should be included in the list as they are actually aliases to *char arrays. Do we get clashes when string is used in a Cap'n Proto struct or enum?

kookman commented 7 years ago

I’m not sure. I just figured it was unwise to leave them unescaped as the string types (+ size_t and ptrdiff_t) are almost keywords in D (being aliases defined in object.d).

On 8 July 2017 at 17:27, Thomas Brix Larsen notifications@github.com wrote:

Thanks. I don't think that dstring/string/wstring should be included in the list as they are actually aliases to *char arrays. Do we get clashes when string is used in a Cap'n Proto struct or enum?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/capnproto/capnproto-dlang/pull/6#issuecomment-313840348, or mute the thread https://github.com/notifications/unsubscribe-auth/AL8Z8aHZT4jkISIOrfr-MJhlFxHJ4k4Sks5sLy9ugaJpZM4ORp63 .

ThomasBrixLarsen commented 7 years ago

Could you please split this into two PRs?

ThomasBrixLarsen commented 7 years ago

I'm actually using string as an identifier in a project using Cap'n Proto and it works fine. If you remove "keywords" defined in object.d I'll merge the "Correct Dlang keywords." commit.

kookman commented 7 years ago

Ok, I've split out the properties work onto a separate branch for now (sorry, didn't intend for them to pile up on each other into this PR). I've removed the aliases from the keyword lists. I think this should be good to go now.