search

capnproto / capnproto-java

Cap'n Proto in pure Java
Other
405 stars 86 forks source link

Enable overriding `pkg-config`'s path with an environment variable #106

Closed ajelinski closed 3 years ago

ajelinski commented 3 years ago

Some build systems require using tools with custom names, e.g., prefixed with architecture.

It'd be much easier to specify proper pkg-config if this line: https://github.com/capnproto/capnproto-java/blob/cd3ef7216635943756ce636fc03aabd4d27a1c05/Makefile#L1 was:

PKG_CONFIG ?= pkg-config
CAPNP_CXX_FLAGS=$(shell $(PKG_CONFIG) capnp --cflags --libs)
dwrensha commented 3 years ago

Sounds good to me. Want to submit a pull request?

ajelinski commented 3 years ago

Sounds good to me. Want to submit a pull request?

Submitted.