search

capnproto / capnproto-java

Cap'n Proto in pure Java
Other
391 stars 86 forks source link

Makefile: Use 'install' to install and respect DESTDIR #119

Open Flowdalic opened 2 years ago

Flowdalic commented 2 years ago

Gentoo uses a staged install mechanism, and hence likes to have DESTDIR :)

paxel commented 2 years ago

does not solve the problem. you should check if destdir is empty and replace it in that case with a single dot.

that would result in . /$prefix which would be relative again.

Florian Schmaus @.***> schrieb am Mi., 22. Dez. 2021, 16:40:

@.**** commented on this pull request.

In Makefile https://github.com/capnproto/capnproto-java/pull/119#discussion_r773983353 :

@@ -26,10 +26,8 @@ capnpc-java : $(CAPNPC_JAVA_SOURCES) $(CXX) $(CAPNPC_JAVA_SOURCES) $(CXX_FLAGS) -o capnpc-java

install:

  • mkdir -p ${PREFIX}/bin
  • mkdir -p ${PREFIX}/include/capnp/
  • cp capnpc-java ${PREFIX}/bin
  • cp compiler/src/main/schema/capnp/java.capnp ${PREFIX}/include/capnp/
  • install -D capnpc-java "${DESTDIR}/${PREFIX}"/bin/capnpc-java

If you are saying that I should remove the explicit / between DESTDIR and PREFIX, then I am happy to do so. :)

— Reply to this email directly, view it on GitHub https://github.com/capnproto/capnproto-java/pull/119#discussion_r773983353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLHGDDOH5DTNWHKOZNXRTUSHWQXANCNFSM5KNCD5LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Flowdalic commented 2 years ago

does not solve the problem. you should check if destdir is empty and replace it in that case with a single dot. that would result in . /$prefix which would be relative again.

I fear I don't see how this doesn't solve the problem: if PREFIX is usr/foo and DESTDIR is empty, then the result, assuming the / between DESTDIR and PREFIX is removed, is also relativ, even though it has no trailing ./.

paxel commented 2 years ago

I thought it's about the security issue of using a specific prefix to write into absolute system paths.

but maybe I'm wrong. apologies.

Florian Schmaus @.***> schrieb am Mi., 22. Dez. 2021, 21:16:

does not solve the problem. you should check if destdir is empty and replace it in that case with a single dot. that would result in . /$prefix which would be relative again.

I fear I don't see how this doesn't solve the problem: if PREFIX is usr/foo and DESTDIR is empty, then the result, assuming the / between DESTDIR and PREFIX is removed, is also relativ, even though it has no trailing ./.

— Reply to this email directly, view it on GitHub https://github.com/capnproto/capnproto-java/pull/119#issuecomment-999837898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLHGEQK6UNMOOJERZXND3USIW2JANCNFSM5KNCD5LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>