capnproto / capnproto-java

Cap'n Proto in pure Java
Other
397 stars 85 forks source link

Support MSVC compiler #133

Closed jonahbeckford closed 1 year ago

jonahbeckford commented 1 year ago

Tested in PowerShell with:

$env:PATH += ";$PWD\dependencies\capnproto-java\install\bin"

dependencies\capnproto\install\bin\capnp.exe compile -ojava `
  -Idependencies/capnproto-java/install/include `
  _deps/capnpc-java-src/examples/src/main/schema/addressbook.capnp
dwrensha commented 1 year ago

Thanks! Prompted by this PR, I switched capnpc-java to start using kj::filesystem rather than the raw unix API: https://github.com/capnproto/capnproto-java/commit/f79453cadc7a411f56adf77cef937b2bf3ab144a

Does that fix compilation for you?

jonahbeckford commented 1 year ago

Yep. The commit 23241424: remove unix-specific includes in capnpc-java compiles on MSVC and passes the test in the PR description.

Thanks! I'll close this now unnecessary PR.