search

capnproto / capnproto-rust

Cap'n Proto for Rust
MIT License
2.06k stars 222 forks source link

optimization: allow `Finish` message to be elided when not needed #514

Closed dwrensha closed 2 months ago

dwrensha commented 2 months ago

Follows this capnproto-c++ commit: https://github.com/capnproto/capnproto/commit/d8efac8788343cb29eee1ba5c5bbb9a7bd9e38ad

dwrensha commented 2 months ago

@SteveLauC: I tried this PR on the benchmark you linked here: https://github.com/capnproto/capnproto-rust/issues/197#issuecomment-2143660999

I saw a roughly 20% increase in QPS.

SteveLauC commented 2 months ago

@SteveLauC: I tried this PR on the benchmark you linked here: #197 (comment)

I saw a roughly 20% increase in QPS.

Amazing! Thanks, I will re-benchmark and update the results there:)

SteveLauC commented 2 months ago

I saw a roughly 20% increase in QPS.

Yeah, confirmed from my benchmark, thanks for the work!

Screenshot 2024-09-14 at 10 01 24 PM