search

capnproto / pycapnp

Cap'n Proto serialization/RPC system - Python bindings
BSD 2-Clause "Simplified" License
459 stars 124 forks source link

Improve LGTM C/C++ code rating #264

Open haata opened 3 years ago

haata commented 3 years ago

Python is currently A+. There's no reason why the C/C++ code can't be just as high.

jayvdb commented 3 years ago

lgtm C++ is giving a rating of "C".

The only lgtm C++ alert is about

No matching copy assignment operator in class PyRefCounter. It is good practice to match a copy constructor with a copy assignment operator.

Maybe try fixing that and see what happens?

https://lgtm.com/help/lgtm/cpp-extraction says only SCons, WAF, Ninja, or Make are supported automatic builders. Perhaps we need to create a lgtm.yml with steps to build, so that it can give a higher score?