search

capnproto / pycapnp

Cap'n Proto serialization/RPC system - Python bindings
BSD 2-Clause "Simplified" License
458 stars 125 forks source link

Disable the use of ninja for windows builds #342

Closed tobiasah closed 8 months ago

tobiasah commented 8 months ago

Apparently github added ninja to all of there runners now. This causes the windows build to fail. This is expected because we add the architecture as a compiler arg unknown to ninja. Even with this, the build fails.

This commit disables ninja on windows for now. Once we fix the underlying issue with ninja and windows we can reenable it.

@haata I am currently investigating how we could use ninja for windows as well ... but in the meantime, I think its best to disable it explicitly. Not sure if we even want that?

tobiasah commented 8 months ago

The one weird thing is that github nowhere documents that their runners have ninja installed ... also that they added it now for windows-2019 is quite surprising to me ...

haata commented 8 months ago

Ninja does work for Windows but I'm not sure I've ever used it there. Right now the problem is that CMake doesn't seem to support generating Ninja files on Windows so your fix looks good.