search

capofficial / client

CAP protocol web client built with Svelte
https://cap.io
Other
2 stars 4 forks source link

FIxed Overlapping and scrollbar issues #45

Closed devgreek closed 1 year ago

devgreek commented 1 year ago

This PR addresses the issue https://github.com/capofficial/client/issues/37

image

Overlapping was caused by the grid's CSS setting missing an overflow configuration

I fixed this issue by adding overflow to the grid and @media(max-width:600px) grid{} and also the persistent scrollbar is now gone

image

I'm willing to update according to your preferences :) @kappacappa

kappacappa commented 1 year ago

@adebayokehinde thanks, added comment.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
client ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 10:22AM (UTC)
kappacappa commented 1 year ago

@adebayokehinde Thanks, but there is unknown code that has been introduced here: https://github.com/capofficial/client/pull/45/files#diff-b6208c7a9db5387aed5b0cc81577feddf2ca323d7e28bc98c55e2b4fd9b3f808R21

I appreciate your contributions, but I believe the code quality is not sufficient to be eligible for bounties. We're looking for experienced developers who can deliver high quality, tested code from the start.

I encourage you to keep contributing and I'd be happy to look over your future changes as time permits.

devgreek commented 1 year ago

@adebayokehinde Thanks, but there is unknown code that has been introduced here: https://github.com/capofficial/client/pull/45/files#diff-b6208c7a9db5387aed5b0cc81577feddf2ca323d7e28bc98c55e2b4fd9b3f808R21

I appreciate your contributions, but I believe the code quality is not sufficient to be eligible for bounties. We're looking for experienced developers who can deliver high quality, tested code from the start.

I encourage you to keep contributing and I'd be happy to look over your future changes as time permits.

Yes, it's actually work in progress for the next issue, I mistakingly pushed it along side the third commit.

devgreek commented 1 year ago

I removed the unused code :)

kappacappa commented 1 year ago

@adebayokehinde as I understand the change is simply to add the update the overflow on the grid in https://github.com/capofficial/client/pull/45/files#diff-f1e97e15940e636ecad4710211e6c199334c75d3f29968b579c39129bd557378

If so, can you please discard any changes to other files as they would not make sense as part of this commit.

devgreek commented 1 year ago

@adebayokehinde as I understand the change is simply to add the update the overflow on the grid in https://github.com/capofficial/client/pull/45/files#diff-f1e97e15940e636ecad4710211e6c199334c75d3f29968b579c39129bd557378

If so, can you please discard any changes to other files as they would not make sense as part of this commit.

Done, kindly review and please let me know if I met your desired changes

kappacappa commented 1 year ago

@adebayokehinde thanks, can you please confirm it is working as expected on your local machine, with different window sizes, or in mobile device simulators? If so, I'll merge.

devgreek commented 1 year ago

@adebayokehinde thanks, can you please confirm it is working as expected on your local machine, with different window sizes, or in mobile device simulators? If so, I'll merge.

Yes it works well on my local machine, I tested on all mobile device simulators On desktop, it works fine even down to 600px in width, no overlapping