Add dark mode

[mystiquewolf]

Hi and thanks for the great extension. It would be awesome if there was a dark mode - if VS Code has a dark theme - use dark mode in the extension. But also allow manually overriding the dark/light theme.

[caponetto]

Hi @mystiquewolf, thanks for reaching out! That's a great idea. In fact, I've already considered it but, since this extension is just a wrapper for the diff2html library, I believe it would make more sense if diff2html provided such a feature out of the box.

[mystiquewolf]

So should we file an issue there?

[caponetto]

Sounds good to me :)

[mystiquewolf]

^^

[caponetto]

Thanks, @mystiquewolf! I really appreciate your contribution! 😃

[caponetto]

Closing due to inactivity of https://github.com/rtfpessoa/diff2html/issues/403.

[tjx666]

@caponetto https://github.com/rtfpessoa/diff2html/issues/403 had been completed

[bombillazo]

Awesome! Seems like this is now possible for this plugin!

[iliyang]

Awesome! Seems like this is now possible for this plugin!

Can you please elaborate how to switch on dark mode in diff viewer? Thanks!

[bombillazo]

I mean, as in this is now possible for the diff viewer, not that it has been implemented. Sorry for the confusion, hopefully @caponetto or someone else will incorporate it to the extension soon :)

[caponetto]

IMO we'll need to have one additional property in the extension settings to change the theme, and, based on this configuration, we can pass the appropriated value of ColorSchemeType to diff2html. It sounds simple, but we'll probably need to tweak some CSS properties for both light and dark themes to make them look good.

I'll work on this eventually when I have some free time. If anyone wants to jump in, feel free to start. I'll be glad to give some pointers. :)

[bombillazo]

Im willing to help, but Im new to VS code extension dev, at least having the option setting present to start the tweaking is a move forward.

[caponetto]

Great @bombillazo! I will include the theme configuration in a branch and share some pointers :)

[bombillazo]

Nice @caponetto , let me know which branch so I can take a look

[caponetto]

@bombillazo Thanks for your availability! I started to prepare the branch but ended up doing the rest of the required changes. A new release will be done soon :)

https://github.com/caponetto/vscode-diff-viewer/assets/638737/56d7e521-2855-4bcb-ab2a-42e1f8c868f3

[bombillazo]

Beautiful, cant wait for this!

[bombillazo]

When can we expect a release?

[caponetto]

Early November :) You can install the current version from main if you want to give it a try. The artifact is available in the last CI run [1].

[1] https://github.com/caponetto/vscode-diff-viewer/actions/runs/6606054496