search

caponetto / vscode-diff-viewer

A simple VS Code extension to easily visualize git diff files.
https://marketplace.visualstudio.com/items?itemName=caponetto.vscode-diff-viewer&ssr=false#overview
MIT License
44 stars 5 forks source link

Click on line number or filename to go to the file #45

Closed jacekkopecky closed 2 years ago

jacekkopecky commented 2 years ago

This PR lets the user click on filenames (in the header of that file's patch) and on line numbers (only line numbers in the new file) to open that file (on that line), which works well for git diffs.

jacekkopecky commented 2 years ago

Thank you @caponetto , good comments as usual; this time I may not get back to this until the weekend so please don't hold your breath. 8-)

caponetto commented 2 years ago

Take your time, @jacekkopecky! I really appreciate your help. :)

caponetto commented 2 years ago

Hi @jacekkopecky, I'm planning to do a refactoring on the entire repo. There are some things to fix, update and improve. This will likely conflict with the work you've been doing on this PR. So should I wait for you to conclude this PR or can I move forward? I can even include the code that you are proposing on this PR as part of this refactoring.

jacekkopecky commented 2 years ago

Please don't wait @caponetto , I won't mind doing it again, it's good exercise. 8-) I'm busy vacationing now anyway. Please @ me when done.

caponetto commented 2 years ago

Great! Enjoy your time off @jacekkopecky :)

caponetto commented 2 years ago

Hey @jacekkopecky, I just merged https://github.com/caponetto/vscode-diff-viewer/pull/48. As you can see in the description, it includes a few improvements. :)

I also took the opportunity to implement the "Click on line number or filename to go to the file" feature because it was a nice use case for me to validate the new message exchange mechanism. I used most of the code from this PR (thanks for that). So I'm closing this PR.

If you find any issues, please let me know.

BTW, please open a Discussion regarding the "save viewed state in the diff file" feature and explain your ideas before starting to work on it. :)

jacekkopecky commented 2 years ago

Thanks @caponetto, that's great! I've opened the discussion item: #50