Add progress bar for viewed files

caponetto / vscode-diff-viewer

A simple VS Code extension to easily visualize git diff files.

https://marketplace.visualstudio.com/items?itemName=caponetto.vscode-diff-viewer&ssr=false#overview

MIT License

44 stars 5 forks source link

Add progress bar for viewed files #70

Closed caponetto closed 1 year ago

caponetto commented 1 year ago

Also reverted to bottom: 0px in the footer but there is still a transition issue to be fixed (the footer moves up and down).

https://user-images.githubusercontent.com/638737/213889855-7cc1da75-7084-417f-b5c7-f6f8a7f9fa62.mov

jacekkopecky commented 1 year ago

Nice!

It's strange that the footer moves when the scrollbar appears; I've tried to find the problem and now I think that it's VSCode's custom scrollbar machinery that somehow causes that. When I added overflow-y: scroll to the webview body, a second scrollbar showed up and things behave weird, but the up/down movement went away. Also, the issue is already there in released versions – it wasn't introduced by any recent changes.

Therefore, please don't let this hold up the next release. 8-)

caponetto commented 1 year ago

Thanks for the analysis, @jacekkopecky! I will open an issue to keep tracking it and proceed with the release. Probably on next Wednesday.