caponica / AmazonMwsComplete

Name-spaced wrappers for the full set of Amazon MWS client libraries
56 stars 53 forks source link

Can't request PARAM_REQUESTED_FROM_DATE for getReport #2

Closed maykino closed 7 years ago

maykino commented 7 years ago

It seems like the callRequestReport doesn't accept startDate so every request defaults to now() pretty much which doesn't generate any records in the report.

caponica commented 7 years ago

There was a note in MwsFeedAndReportClientPack that it wasn't implemented yet. I've done it now (in 4722d17) - let me know if it's working as expected.

maykino commented 7 years ago

Thank you very much! I'm going to test it shortly!

M.

On Sun, Nov 20, 2016 at 6:09 PM, Christian Morgan notifications@github.com wrote:

There was a note in MwsFeedAndReportClientPack that it wasn't implemented yet. I've done it now (in 4722d17 https://github.com/caponica/AmazonMwsComplete/commit/4722d1792847feb55533c7f385011d7d795ffcf2)

  • let me know if it's working as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caponica/AmazonMwsComplete/issues/2#issuecomment-261826113, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPBWjiMw31AHzR65Gf97VZtK5uB1o2Zks5rAP1MgaJpZM4K3C_Z .

maykino commented 7 years ago

Do you also mind adding report_type to callGetReportRequestList? It should be not required by default.

Thank you

On Mon, Nov 21, 2016 at 11:10 PM, Michael Gawrychowski < michael@gawrychowski.com> wrote:

Thank you very much! I'm going to test it shortly!

M.

On Sun, Nov 20, 2016 at 6:09 PM, Christian Morgan < notifications@github.com> wrote:

There was a note in MwsFeedAndReportClientPack that it wasn't implemented yet. I've done it now (in 4722d17 https://github.com/caponica/AmazonMwsComplete/commit/4722d1792847feb55533c7f385011d7d795ffcf2)

  • let me know if it's working as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caponica/AmazonMwsComplete/issues/2#issuecomment-261826113, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPBWjiMw31AHzR65Gf97VZtK5uB1o2Zks5rAP1MgaJpZM4K3C_Z .

maykino commented 7 years ago

Actually it should be passed as an associative array something like this:

self::PARAM_REPORT_TYPE_LIST => array('Type' => $reportType),

On Tue, Nov 22, 2016 at 11:04 PM, Michael Gawrychowski < michael@gawrychowski.com> wrote:

Do you also mind adding report_type to callGetReportRequestList? It should be not required by default.

Thank you

On Mon, Nov 21, 2016 at 11:10 PM, Michael Gawrychowski < michael@gawrychowski.com> wrote:

Thank you very much! I'm going to test it shortly!

M.

On Sun, Nov 20, 2016 at 6:09 PM, Christian Morgan < notifications@github.com> wrote:

There was a note in MwsFeedAndReportClientPack that it wasn't implemented yet. I've done it now (in 4722d17 https://github.com/caponica/AmazonMwsComplete/commit/4722d1792847feb55533c7f385011d7d795ffcf2)

  • let me know if it's working as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caponica/AmazonMwsComplete/issues/2#issuecomment-261826113, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPBWjiMw31AHzR65Gf97VZtK5uB1o2Zks5rAP1MgaJpZM4K3C_Z .

caponica commented 7 years ago

I have added these options in 7c217c0 - let me know if they all work as expected

maykino commented 7 years ago

I think I added them as well to my fork... Thanks anyways!

On Mon, Dec 5, 2016 at 10:36 AM, Christian Morgan notifications@github.com wrote:

I have added these options in 7c217c0 https://github.com/caponica/AmazonMwsComplete/commit/7c217c0ac58b769fd5a8ce0bf35b6d21d3f7c12d

  • let me know if they all work as expected

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caponica/AmazonMwsComplete/issues/2#issuecomment-264937226, or mute the thread https://github.com/notifications/unsubscribe-auth/AEPBWs-AN-v6x7pjgka-HQsvlDv6GozAks5rFFmwgaJpZM4K3C_Z .

caponica commented 7 years ago

You know... that's what pull requests are for ;-)