search

caponica / AmazonMwsComplete

Name-spaced wrappers for the full set of Amazon MWS client libraries
56 stars 53 forks source link

Add FBA Inventory and Inbound Client Packs #38

Closed jasonhebert closed 5 years ago

jasonhebert commented 5 years ago

Add FbaInventoryClientPack. Add FbaInboundClientPack. Add domain objects for FBA Inventory reports.

caponica commented 5 years ago

I'm flat out with pre-Christmas retail things at the moment but I'll try to review this (and all other PRs) before the end of the year. Thank you for contributing!

jasonhebert commented 5 years ago

No worries. I think there may be a bug in the FBA Inbound piece that I'm working out atm. It's difficult to debug without a sandbox env to work with ;)

caponica commented 5 years ago

I know, right? Amazon, the same company as AWS and IAM, cannot even give you a sandbox or any kind of control over API keys. Not even a readonly API key... 😭

jasonhebert commented 5 years ago

Their advertising API is much better in the fact that the library is more up to date and doesn't use XML. Plus, it has a sandbox. Problem with their sandbox is that it is tied to your account alone and is empty, no test data to use in it so it is like you are starting a company from scratch and have to populate everything yourself if you want to run any kind of testing there. But it at lease DOES have a sandbox.

jasonhebert commented 5 years ago

The issue I had is now corrected.

caponica commented 5 years ago

Thanks for the update - I'll review it soon!

caponica commented 5 years ago

Looks great - thank you for the detailed contribution!