caponica / AmazonMwsComplete

Name-spaced wrappers for the full set of Amazon MWS client libraries
56 stars 53 forks source link

Make private methods protected #49

Open colinmollenhour opened 4 years ago

colinmollenhour commented 4 years ago

Thanks for your work on this library, Christian!

What are your thoughts on replacing all private method declarations with protected?

We're having a strange issue where some XML responses from Amazon are partially corrupt, like XML tags that are combined with each other, nested incorrectly, etc. Since the Amazon library only returns the parsed XML and not the raw response text we can't log this to see exactly what is getting returned and since it uses private methods we can't easily override the Amazon code to inject our logger code.