search

caporaso-lab / mockrobiota

A public resource for microbiome bioinformatics benchmarking using artificially constructed (i.e., mock) communities.
http://mockrobiota.caporasolab.us
BSD 3-Clause "New" or "Revised" License
77 stars 35 forks source link

Updated documentation and inventory #39

Closed nbokulich closed 8 years ago

nbokulich commented 8 years ago

Checks fail because one FTP link is missing. This link is a placeholder for data to be added this week in response to issue-7

gregcaporaso commented 8 years ago

@nbokulich, can you check that CONTRIBUTING.md is updated to reflect that tabular data files no longer start with a leading # (i.e., the change made in #40).

gregcaporaso commented 8 years ago

Done reviewing this one @nbokulich.

nbokulich commented 8 years ago

Thanks @gregcaporaso I will make all changes above and then merge.

A couple changes (e.g., physical-specimen-contact --> contact-email in all other dataset metadata) will be in a separate PR. Wanted to get this PR and PR#40 through before making more changes to these files.

gregcaporaso commented 8 years ago

Ok, makes sense. Thanks!

nbokulich commented 8 years ago

@gregcaporaso I have updated CONTRIBUTING.md to reflect that tabular data files no longer start with a leading # (i.e., the change made in #40). However, the document calls these "classic biom files" — without the leading "#", these are no longer classic biom format, correct?

gregcaporaso commented 8 years ago

re: "classic biom files"

Good point - let's just drop that as the description of those files.

nbokulich commented 8 years ago

Got it. Am dropping those and will squash/merge this PR

On Thu, Sep 8, 2016 at 9:51 AM, Greg Caporaso notifications@github.com wrote:

re: "classic biom files"

Good point - let's just drop that as the description of those files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/caporaso-lab/mockrobiota/pull/39#issuecomment-245623517, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0bbPdZlHM5CglPYs0Ae1Puvi5mCsuiks5qoCDigaJpZM4J2B0E .

gregcaporaso commented 8 years ago

I can do the final merge (generally someone else merges, not the person who submits).

nbokulich commented 8 years ago

Got it, @gregcaporaso . I am done making the requested changes. I have added line notes to spots in CONTRIBUTING.md where I have made new changes that were not specifically mentioned in your line notes (e.g., remove classic biom format details) to make it easier to spot all new changes.