MAINT: Makes compatible with latest pandas

caporaso-lab / sourcetracker2

SourceTracker2

BSD 3-Clause "New" or "Revised" License

61 stars 45 forks source link

MAINT: Makes compatible with latest pandas #112

Closed johnchase closed 5 years ago

johnchase commented 5 years ago

Fixes #111 Pandas changed the reduce functionality in df.apply http://pandas.pydata.org/pandas-docs/stable/whatsnew.html?highlight=rolling_mean#changes-to-make-output-of-dataframe-apply-consistent the new api is backwards incompatible with >0.23.4. The changes in this pull request work with both versions of pandas. There may be a better way to achieve this, though I think either way it is preferable to keep sourcetracker compatible with the recent versions of pandas

coveralls commented 5 years ago

Coverage increased (+0.003%) to 99.225% when pulling e9ea03cfde2bd2d5e7f08d53703797e6bce0ce3e on johnchase:issue_111 into 889f40906bd224786f0be128bc99b0c7fb1ad41c on biota:master.

rebelwebster commented 5 years ago

Any closer to having this merged?

lkursell commented 5 years ago

@johnchase - looks good. Is it worth mentioning in the change log the version of pandas that ST becomes non backwards compatible with? Also, we could update the setup.py to include pandas > >= 0.23.4

johnchase commented 5 years ago

This update makes sourcetracker compatible with all versions of pandas