Filter - Githubissues

caporaso-lab / sourcetracker2

SourceTracker2

BSD 3-Clause "New" or "Revised" License

60 stars 45 forks source link

Filter #122

Open johnchase opened 5 years ago

johnchase commented 5 years ago

Adds the option to filter zero counts from a sourcetracker analysis (When both a given sink and source have zero counts)
Removes the left out sample from the feature assignment tables when run with LOO=True Previously this was populated with all zeros

johnchase commented 5 years ago

@wdwvt1 We haven't really discussed this in detail. If this is not appropriate to add to master, we can close the pull request and I can maintain the code in another repo.

coveralls commented 5 years ago

Coverage increased (+0.4%) to 100.0% when pulling d5a673c250b317151337d2e9d05bc5e2835f0e0d on filter into 4f52d7fab10c0d307b14e9ca7627e57a531d7a6d on master.

johnchase commented 4 years ago

Flake8 errors, will fix soon

jkliu commented 4 years ago

Tested branch on a dataset that was previously returning the incorrect columns/features when using filter_zero_counts=True for filtering. Rerunning branch on the same dataset now returns a feature assignment table with a set of columns/features that is a subset to the set of columns/features that went into gibbs()