search

caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
60 stars 45 forks source link

Diagnostics addition to sourcetracker #152

Closed andy6a closed 6 months ago

andy6a commented 10 months ago

Please test this code and let me know what you would like to do with it, may not fully follow code standards so let me know what you think

andy6a commented 10 months ago

Those changes look great I didn't have it in code format because I was having an error with diagnostics that I was just trying to solve quickly so that looks great to me! Let me know if I need to do anything else for this!

cherman2 commented 10 months ago

Hi @andy6a, Could you take a look at the flake8 errors (By clicking on the failed check) and fix those errors that are causing that check to fail?

wasade commented 7 months ago

Not sure if relevant to this PR, but please note that refactoring to reduce dependence on dense matrices, and greatly reduce resident memory requirements, is part of this branch. It would be pleasant to figure out how we can get the useful changes merged into master

andy6a commented 7 months ago

Man it is really picky about line numbers. That said I got it done, sorry that took so long.