caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
62 stars 45 forks source link

ipcluster can remain open in some circumstances #20

Closed gregcaporaso closed 5 years ago

gregcaporaso commented 8 years ago

From @wdwvt1 on February 27, 2016 7:40

If a user deletes the output folder that has been created before all the jobs launched by IPcluster have finished, the cluster will fail to shut itself down. This could cause serious resource leaks.

_Copied from original issue: biota/sourcetracker2internal#23

wdwvt1 commented 8 years ago

@gregcaporaso noted that we need to close the cluster if gibbs or gibbs_loo fail.

wdwvt1 commented 8 years ago

@wasade mentioned using the atexit functionality here

wasade commented 8 years ago

It might be worth replacing ipcluster with joblib, although I don't know how coupled the codebase is at this time. Joblib is super simple, performant, what scikit-learn uses, and can use a ipython cluster backend anyway if it is necessary to span multiple nodes

johnchase commented 5 years ago

@wdwvt1 this should be fixed by #117