search

caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
62 stars 45 forks source link

delay parameter #33

Closed wdwvt1 closed 8 years ago

wdwvt1 commented 8 years ago

if the delay parameter in the gibbs_sampler function is set to 1 the function will never take draws (x-y mod 1 always = 0).

this is a legacy from the original sourcetracker code. we need to establish if there is any reason that a delay of 1 is unacceptable and rewrite the checker if not.

wdwvt1 commented 8 years ago

got bitten by this bug this morning - need to get this figured out.

lkursell commented 8 years ago

It sounds reasonable that someone would want to collect every draw after a certain burn in period, so we should allow it

On Apr 17, 2016, at 5:56 PM, Will Van Treuren notifications@github.com wrote:

if the delay parameter in the gibbs_sampler function is set to 1 the function will never take draws (x-y mod 1 always = 0).

this is a legacy from the original sourcetracker code. we need to establish if there is any reason that a delay of 1 is unacceptable and rewrite the checker if not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/biota/sourcetracker2/issues/33