search

caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
61 stars 45 forks source link

Api #71

Closed wdwvt1 closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.2%) to 96.457% when pulling c3c597086d78adb94b78d56aa71d82ece3688d68 on wdwvt1:api into 7b0c89b6b099efc2baf0e1276cee9c9c795120fc on biota:master.

wdwvt1 commented 7 years ago

@gregcaporaso - I tried to squash commits. That went predictably well, so the history is a little screwed up. The coverage decreased because I added the plotting function (nothing to test there), but otherwise I think it should be ready for your review.

gregcaporaso commented 7 years ago

@wdwvt1, I'm done reviewing.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.2%) to 96.484% when pulling e69dcb397b05e80eaf375c2ab1264ebe02dbaf50 on wdwvt1:api into 7b0c89b6b099efc2baf0e1276cee9c9c795120fc on biota:master.

wdwvt1 commented 7 years ago

@gregcaporaso - done addressing changes. thanks for review - ready for another look/merge/discussion.

gregcaporaso commented 7 years ago

@wdwvt1, just one question (see my comment on the ChangeLog) and then this should be good for merge.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.2%) to 96.484% when pulling 909c1b81ec42a826f0441c94ab75a34068d9a85c on wdwvt1:api into 7b0c89b6b099efc2baf0e1276cee9c9c795120fc on biota:master.

gregcaporaso commented 7 years ago

Looks good! I just thought of two more things (#73 and #74) which we should address in another PR prior to release.