~55% speed improvement - Githubissues

caporaso-lab / sourcetracker2

SourceTracker2

BSD 3-Clause "New" or "Revised" License

65 stars 46 forks source link

~55% speed improvement #80

Closed wdwvt1 closed 8 years ago

wdwvt1 commented 8 years ago

This references issue #79, and uses a slightly different replacement for np.random.choice to get the same speed improvement without changing the number or nature of the calls to the prng.

coveralls commented 8 years ago

Coverage remained the same at 99.228% when pulling 0465734a1482187509809d4403b18dffa78124e1 on wdwvt1:speed into ef3d7adf50ed9e92a914e9e3dcd55bfc1c46d859 on biota:master.

coveralls commented 8 years ago

Coverage remained the same at 99.228% when pulling 22132682017b10ac08d3ea0e9785b6ebf8bbbaa2 on wdwvt1:speed into ef3d7adf50ed9e92a914e9e3dcd55bfc1c46d859 on biota:master.

wdwvt1 commented 8 years ago

@gregcaporaso - all the tests pass, but I've changed the innermost loops of gibbs_sampler so I'd like you to take a look whenever you have a chance.

wasade commented 8 years ago

This is pretty cool :)

gregcaporaso commented 8 years ago

Looks good, thanks @wdwvt1!

wdwvt1 commented 8 years ago

Thanks Greg!

On Fri, Sep 23, 2016 at 8:26 AM, Greg Caporaso notifications@github.com wrote:

Merged #80 https://github.com/biota/sourcetracker2/pull/80.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biota/sourcetracker2/pull/80#event-800558464, or mute the thread https://github.com/notifications/unsubscribe-auth/AA__-V8IDCW7umlzTxupIRLVTmDNKB-sks5qs--ogaJpZM4J8inm .