caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
61 stars 45 forks source link

Per_sink_feature_assignments not found #85

Closed dsouzamel closed 4 years ago

dsouzamel commented 7 years ago

I re-installed sourcetracker2 to use the new, added feature --per_sink_feature_assignments and get the following error:

Error: no such option: --per_sink_feature_assignments

This feature was added: https://github.com/biota/sourcetracker2/issues/52#issuecomment-234599669

wdwvt1 commented 7 years ago

hi @dsouzamel - how did you install st2? the code currently has that parameter (at this line), and the latest build has tests of that feature suggesting its working. My best guess is that you've somehow installed an older branch.

dsouzamel commented 7 years ago

Hey - I used the pip install instructions in conda. I do everything in terminal as per installation instructions (i.e. pip install sourcetracker). How do I uninstall and re-install sourcetracker from a newer branch? Thanks.

On Oct 6, 2016 19:55, "Will Van Treuren" notifications@github.com wrote:

hi @dsouzamel https://github.com/dsouzamel - how did you install st2? the code currently has that parameter (at this line) https://github.com/biota/sourcetracker2/blob/master/sourcetracker/_cli/gibbs.py#L109, and the latest build has tests of that feature suggesting its working. My best guess is that you've somehow installed an older branch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biota/sourcetracker2/issues/85#issuecomment-252128218, or mute the thread https://github.com/notifications/unsubscribe-auth/AVjVlU6lpNn9dCNQhBKDBY1XsiPOOO9nks5qxZh6gaJpZM4KM1on .

wdwvt1 commented 7 years ago

Ahh - pip still must not be updated to the latest version. To resolve that, you can give pip a specific link to download from. So do:

source activate whatever_your_st2_env_is
pip uninstall sourcetracker2
pip install https://github.com/biota/sourcetracker2/archive/master.zip
# if that fails, try http://github.com/biota/sourcetracker2/archive/master.zip

@gregcaporaso - can you update pip with the latest master branch?

gregcaporaso commented 7 years ago

@gregcaporaso - can you update pip with the latest master branch?

That's not possible to do - we need to have a release and then upload it to pypi for pip to find it. Should we be thinking about a release? I could help the week of 10/17 (after I get back from the Iceland workshop).

wdwvt1 commented 7 years ago

@gregcaporaso - ahh, I definitely misunderstood how pip/pypi works, thanks for the explanation. I'll come up with a plan for a set of milestones and then we can chat offline.

dsouzamel commented 7 years ago

Hey, so I tried that and now I get a new message (see below) and the progam does nothing anymore:

/Users/labadmin/anaconda3/envs/st2/lib/python3.5/site-packages/IPython/html.py:14: ShimWarning: The IPython.html package has been deprecated. You should import from notebook instead. IPython.html.widgets has moved to ipywidgets. "IPython.html.widgets has moved to ipywidgets.", ShimWarning)

wdwvt1 commented 7 years ago

That is just an expected warning from Ipython - it's not related to ST2 - and doesn't indicate any problems.

When you say "does nothing anymore" what do you mean?

If you activate your st2 environment, then issue the command sourcetracker2 gibbs --help, what do you get as the output?

dsouzamel commented 7 years ago

So with sourcetracker2 gibbs --help I get the entire help function write out.

When I run it with real samples (i.e. with a mapfile and biom file) I get no output besides output folder creation. That folder sits empty for 20 mins (before which I kill the job).

wdwvt1 commented 7 years ago

That strongly suggests you are killing the job before its finished. You need to wait longer. To verify this is the case try using your data with much less computationally demanding parameters. For instance, try:

sourcetracker2 gibbs -i /whatever/your/table/fp/is.biom -m /whatever/your/map/fp/is.txt -o /out/path/ --restarts 1 --draws_per_restart 1 --burnin 15 --delay 1 --source_rarefaction_depth 1000 --sink_rarefaction_depth 1000

These are fast running parameters which should finish in 20 minutes given the following things.

  1. You have a reasonably sized data set, e.g. less than 500 sink samples.
  2. You have available RAM and are not swapping to hard disk. If you don't know what this means, look it up - its one of the most common causes of long running times.
  3. You have free processors on your computer.
dsouzamel commented 7 years ago

In the previous version of Sourcetracker2 intermediate files for each sample were produced and not just the 3 files hence the impatience on job completion. I see that in the newerversion it spits out 3 files at the end of the job and I now know I have to wait a couple of hours for a bigger job. Cheers!

adityabandla commented 4 years ago

Can the installation instructions be modified please to reflect this? The package available through pip seems to have multiple issues

johnchase commented 4 years ago

Hi @adityabandla I opened a new issue #123. I am closing this issue as it is outdated.

If you are interested in updating the installation instructions and issuing a pull request it would be much appreciated!