search

caporaso-lab / sourcetracker2

SourceTracker2
BSD 3-Clause "New" or "Revised" License
61 stars 45 forks source link

Autoc #89

Open wdwvt1 opened 7 years ago

wdwvt1 commented 7 years ago

hmm, not sure how i got all these other commits in there. this is for initial review and then we can discuss parameters.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-7.9%) to 91.29% when pulling 05771a8cb756f761bcbb86045da884ec274d2bfb on wdwvt1:autoc into f01d11b22c279975a98c8e3a6bc3b012fe6fd5cc on biota:master.

lkursell commented 7 years ago

@gregcaporaso Can you review this pull request?

gregcaporaso commented 7 years ago

I can review this over the weekend.

gregcaporaso commented 7 years ago

@wdwvt1, it looks like this was built on a branch containing the commits in #83, which is why those commits are in here. This therefore seems to contain all of the changes in that PR as well. It's generally good practice to keep different changes in different PRs - if you want to go with that approach, you could git checkout master, git pull upstream master, and then copy you changes over to a new branch and submit that in a new PR.

wdwvt1 commented 7 years ago

you are tottaly right - i am not sure how i managed to do that :/. thanks for all the comments! i will clean these up and submit a new PR.

On Sat, Feb 18, 2017 at 12:36 PM, Greg Caporaso notifications@github.com wrote:

@wdwvt1 https://github.com/wdwvt1, it looks like this was built on a branch containing the commits in #83 https://github.com/biota/sourcetracker2/pull/83, which is why those commits are in here. This therefore seems to contain all of the changes in that PR as well. It's generally good practice to keep different changes in different PRs - if you want to go with that approach, you could git checkout master, git pull upstream master, and then copy you changes over to a new branch and submit that in a new PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biota/sourcetracker2/pull/89#issuecomment-280873063, or mute the thread https://github.com/notifications/unsubscribe-auth/AA__-bzJhZKcfRHLJdY3P4E0Il8zuexMks5rd1Y6gaJpZM4L9Z5f .

lkursell commented 6 years ago

@wdwvt1 - any chance to address @gregcaporaso's comments to implement the autoconvergence?