search

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J
https://cappuccino.dev/
GNU Lesser General Public License v2.1
2.21k stars 333 forks source link

Editing issue in a cell of a CPTableView depending on the number of rows #2865

Closed jasperdeb closed 4 years ago

jasperdeb commented 4 years ago

I have encounterd an issue while editing a cell in a CPTableView. A reduction has been made at the link http://por-taal.be/Reduction/. The code of the AppController.j can be found at http://por-taal.be/Reduction/AppController.j.

Depending on the number of lines in the CPTableView (up to 431 lines, or more then 431 lines), a double click in the column at first removes the alternating row colors in the CPTableView, and requires the app to restart.

Screenshot before double click image

Screenshot directly after double click image

Screenshot after a mouse click back on the table view image

@cacaodev @mrcarlberg Do you know where I should begin to look in CPTableView? Because I do not really understand the code of this class to find a clue why this is hapining.

cappbot commented 4 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

mrcarlberg commented 4 years ago

Can you please describe the problem? What do you expect? What is "something weird"?

jasperdeb commented 4 years ago

@mrcarlberg I updated the description.

mrcarlberg commented 4 years ago

Thanks, I do get this in Chrome but not in Firefox or Safari.

mrcarlberg commented 4 years ago

What version of Cappuccino do you use?

jasperdeb commented 4 years ago

As I mainly use Chrome (normally I work on a Windows laptop)I had not tested it, but now working on an iMac and I can confirm this is a Chrome only problem.

The version in the test is the 05/09/2019 version of Didier is work for A3. Should I test with the latest master or 1.0 release to verify?

mrcarlberg commented 4 years ago

Please test it with the latest master.

jasperdeb commented 4 years ago

Just compiled the latest master and updated the reduction with this build, but no change in behaviour.

jasperdeb commented 4 years ago

I have tested with Chrome for Mac versions 60 until 76 and I did not see the bug. Seems to be something new from v77. Chrome for Windows v77 also does not seem to have the problem. Seems to be a very specific Chrome (for Mac) problem...

daboe01 commented 4 years ago

looks like it gets worse in canary 79

Bildschirmfoto 2019-10-07 um 19 26 59
daboe01 commented 4 years ago

@jasperdeb i do not see this in my apps, that do not have zebra mode turned on. could zebra mode be the trigger?

daboe01 commented 4 years ago

-#new +Chrome

cappbot commented 4 years ago

Milestone: Someday. Label: Chrome. What's next? A reviewer should examine this issue.

jasperdeb commented 4 years ago

@daboe01 I have commented out the alternated row colors, and the problem is not gone.

daboe01 commented 4 years ago

@jasperdeb are you 100% sure you see the issue with 1.0?

jasperdeb commented 4 years ago

I compiled the latest master. @daboe01 Do you get other results?

daboe01 commented 4 years ago

@jasperdeb i did not try your reduction on my setup. will do so asap.

daboe01 commented 4 years ago

@jasperdeb i get the same results with the current master. the issue is triggered by returning more than 303 from -numberOfRowsInTableView:

daboe01 commented 4 years ago

@jasperdeb good news: the issue is fixed in chromium Version 79.0.3938.0 (Entwickler-Build) (64-Bit)

jasperdeb commented 4 years ago

ok, I will wait and see if the stable release of Chrome 79 solves the problem, and then close if this is the case.

daboe01 commented 4 years ago

@jasperdeb do you still see this in 78.0.3904.70?

daboe01 commented 4 years ago

@jasperdeb for me it is fixed in the latest 78

jasperdeb commented 4 years ago

I don't see this anymore. Therefore I close this issue...