fixed: key event issues of handling escape in recent firefox …

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J

https://cappuccino.dev/

GNU Lesser General Public License v2.1

2.2k stars 333 forks source link

fixed: key event issues of handling escape in recent firefox … #3020

Closed daboe01 closed 2 years ago

daboe01 commented 2 years ago

…versions recently FF returns "Escape" instead of chr(27) in the key property of keyboard events. This caused the esc key to malfunction in cappuccino on FF.

This PR fixes this by treating esc analogous to webkit. Tested on FF 94.0.2 (64-Bit) for mac.

cappbot commented 2 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

daboe01 commented 2 years ago

+Firefox -#new +AppKit

cappbot commented 2 years ago

Milestone: Someday. Labels: AppKit, FireFox. What's next? A reviewer should examine this issue.

mrcarlberg commented 2 years ago

Merged! Thanks!