search

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J
https://cappuccino.dev/
GNU Lesser General Public License v2.1
2.2k stars 333 forks source link

Revert "New: Support to compile deep structured project in the web browser" #3024

Closed cacaodev closed 2 years ago

cacaodev commented 2 years ago

There is an error at runtime with this commit, let's revert until we find the problem. Reverts cappuccino/cappuccino#2963

cappbot commented 2 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

mrcarlberg commented 2 years ago

@cacaodev What kind of error do you get?

cacaodev commented 2 years ago

@mrcarlberg really sorry for answering so late After jake clean && rm -rf $CAPP_BUILD && jake sudo-install, you can see the error in any Manual test with symlinked frameworks to $CAPP_BUILD, so not using this pr feature. Without the OBJJ_COMPILER_FLAGS "IncludeDebugSymbols", you can see the error in the console: Capture d’écran 2022-03-31 à 10 30 17 "

daboe01 commented 2 years ago

@cacaodev i saw this also recently in latest master, out of the blue. there is most likely a syntax error in the index.html with respect to commata and comments.

cacaodev commented 2 years ago

@daboe01 thank you, good catch ! Embedded comments like this are causing the error: OBJJ_COMPILER_FLAGS = [/*"IncludeDebugSymbols"*/, "IncludeTypeSignatures"/*, "SourceMap"*/, "InlineMsgSend"]; Now in master I don't see the error with the previous line but there is no reason to think it is related to this PR.

michaelbach commented 2 years ago

Then problem is the misplaced comma after */, it should be WITHIN the out-commented part.