search

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J
https://cappuccino.dev/
GNU Lesser General Public License v2.1
2.2k stars 333 forks source link

fixed: å and Å did not work well on scandinavian keyboards in CPTextView #3031

Closed daboe01 closed 2 years ago

daboe01 commented 2 years ago

previously, å and Å had been awkwardly filtered in keyDown: and reinserted via the deadkey handler. this caused a sluggish typing experience for our Skandinavian friends.

this filtering is cleaned up by this PR. deadkey-diacritics still work.

tested on chrome, safari and FF, although only on mac. fixes #3030

daboe01 commented 2 years ago

sorry, i still see issues. will try to fix asap.

cappbot commented 2 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

daboe01 commented 2 years ago

-#new +TextView

daboe01 commented 2 years ago

@mrcarlberg works for me now. please test it and merge at your discretion (also into node, please)

cappbot commented 2 years ago

Milestone: Someday. Label: TextView. What's next? A reviewer should examine this issue.

daboe01 commented 2 years ago

+#ready-to-commit

cappbot commented 2 years ago

Milestone: Someday. Labels: #ready-to-commit, TextView. What's next? The changes for this issue are ready to be committed by a member of the core team.

mrcarlberg commented 2 years ago

Fixes #3030

mrcarlberg commented 2 years ago

Merged! Thanks!