search

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J
https://cappuccino.dev/
GNU Lesser General Public License v2.1
2.2k stars 333 forks source link

Default-Button has wrong colors #3034

Closed daboe01 closed 2 years ago

daboe01 commented 2 years ago

this happens when window becomes key. the button should be blue but is white (you cannot read the text anymore)

daboe01 commented 2 years ago

Bildschirmfoto 2022-04-01 um 10 38 40

daboe01 commented 2 years ago

+Aristo3

cappbot commented 2 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

cappbot commented 2 years ago

Milestone: Someday. Labels: #new, Aristo3. What's next? A reviewer should examine this issue.

daboe01 commented 2 years ago

-#new

cappbot commented 2 years ago

Milestone: Someday. Label: Aristo3. What's next? A reviewer should examine this issue.

mrcarlberg commented 2 years ago

Do you add an image to get the button blue?

didierkorthoudt commented 2 years ago

No, it's done via CSS, using a different theme state.

mrcarlberg commented 2 years ago

I think I saw a new problems some month ago when more attributes where stored on theme state. Do you set for example the bordered attribute ([aButton setBordered:NO];) after you have set the css blue?

mrcarlberg commented 2 years ago

We got problems when setting an image on buttons before we set the bordered attribute. The solution was to set the image last.

daboe01 commented 2 years ago

+#works-for-me it turned out that the button type was wrong. Default buttons must be of type « Push » (as in Cocoa)

cappbot commented 2 years ago

Milestone: Someday. Labels: #works-for-me, Aristo3. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

cappbot commented 2 years ago

Milestone: Someday. Labels: #works-for-me, Aristo3. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.