CPView.j, fix typo: _ephereralSubviews → _ephemeralSubviews. Line #3462 references the correct spelling.

cappuccino / cappuccino

Web Application Framework in JavaScript and Objective-J

https://cappuccino.dev/

GNU Lesser General Public License v2.1

2.2k stars 333 forks source link

CPView.j, fix typo: _ephereralSubviews → _ephemeralSubviews. Line #3462 references the correct spelling. #3041

Closed michaelbach closed 1 year ago

cappbot commented 2 years ago

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

cacaodev commented 1 year ago

Hi michael, it seems you are pushing unrelated changes on the same branch. One pr per feature improvement is needed before any reviewing. Tx

michaelbach commented 1 year ago

Thank You! I understand – I obviously cannot handle git well enough yet. So I'll make a new fork, make changes in CPSlider and issue a new pull request after deleting this one.

daboe01 commented 1 year ago

@michaelbach can you please close this one and reopen the appropriate PRs? IMHO these should make it into the upcoming release.

daboe01 commented 1 year ago

-#new +#needa-improvement

daboe01 commented 1 year ago

+#needs-improvement

michaelbach commented 1 year ago

Closed on request by @daboe01

cappbot commented 1 year ago

Milestone: Someday. Label: #needs-improvement. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.