Support Pytorch MaxP Feature/ptmaxp

capreolus-ir / capreolus

A toolkit for end-to-end neural ad hoc retrieval

https://capreolus.ai

Apache License 2.0

95 stars 32 forks source link

Support Pytorch MaxP Feature/ptmaxp #184

Closed crystina-z closed 2 years ago

crystina-z commented 3 years ago

added PyTorch MaxP
update the output of bertpassage id2vec function, so that it's compatible to both tf-maxp and pt-maxp
update the other extractor accordingly
updated the test case and repro docs

lgtm-com[bot] commented 2 years ago

This pull request introduces 9 alerts when merging db0e40530d7a04dc5fc2aa73f5cc866945195388 into a56830425aac46f9f0dc48134ec2e8bee4e10cc3 - view on LGTM.com

new alerts:

3 for Unused local variable
3 for Unused import
2 for Conflicting attributes in base classes
1 for Module is imported with 'import' and 'import from'

andrewyates commented 2 years ago

I got a reasonable dev MRR with pytorch: 0.3548