search

caprica / picam

Unofficial Java API library for the Raspberry Pi camera.
GNU General Public License v3.0
49 stars 11 forks source link

General cleanup, warning suppression #19

Closed JMY1000 closed 4 years ago

JMY1000 commented 5 years ago

Wasn't sure if you'd want this, but I figured I might as well, so here it is.

Add documentation for some missing args, some more type inference, lots of suppressing warnings.

JMY1000 commented 5 years ago

Apologies for the force pushes, screwed up the author and had to fix it.

JMY1000 commented 5 years ago

The idea was just to suppress warnings that occur when viewing the library as its own project. Since there are lots of parts of the code that aren't used within the library in the same way that they might be used when the library is being used as indented (as a library within another project), a user's development environment might issues warnings that don't hold any bearing.

To put it another way, the warning suppression isn't to suppress warnings that might pop up when using the library, but when developing the library itself.

If you don't think these belong in the library, feel free to close this PR (or I can revise it to just fix the few unlabeled parameters in the Javadoc.)