caprover / caprover-frontend

Frontend App for https://github.com/caprover/caprover
63 stars 91 forks source link

European date format #157

Closed drmrbrewer closed 1 month ago

drmrbrewer commented 1 month ago

Currently the date is displayed in US date format mmddyy:

image

Would be great if there was an option to display it in European date format ddmmyy.

thgh commented 1 month ago

It seems to be using the browser locale

Screenshot 2024-09-23 at 11 16 18
drmrbrewer commented 1 month ago

@thgh on my languages setup page in Chrome I see:

image

IIRC, I have never changed these settings, so they are what they have always been. And based on these settings, it should be showing non-US date format? I can't see any other locale setting to change. I tried overriding the location in DevTools (see here) to Berlin and London, but regardless of location it's still showing US date format in CapRover.

githubsaturn commented 1 month ago

@thgh you're not on the latest version. This is a regression introduced as I was trying to make the column shorter.

drmrbrewer commented 1 week ago

@githubsaturn I just updated to the latest CapRover and it seems that there is no change to the date format... these are today's date (6 Nov 2024):

image

Same for Last Deployed dates on App page:

image

My browser languages settings are unchanged (see above).

githubsaturn commented 1 week ago

See here: https://github.com/caprover/caprover/issues/2185

drmrbrewer commented 1 week ago

OK. Not sure where moment is getting the idea that the date should be in US format, because both browser and system all seem to be set to European/UK date format... I don't see the US format anywhere apart from in CapRover:

system:

image

browser:

image

CapRover:

image

Anyway, hopefully the new fix will do it!

githubsaturn commented 1 week ago

Yea that's weird. Anyways the new fix used built-in Date so it should work 🤞

drmrbrewer commented 6 days ago

Yep, I confirm that it's fixed in 1.13.2, thanks!