search

caprover / caprover-frontend

Frontend App for https://github.com/caprover/caprover
59 stars 83 forks source link

Save captain-definition file when deploying #26

Open hueyy opened 5 years ago

hueyy commented 5 years ago

Is your feature request related to a problem? Please describe. On the deployment screen, when Method 5 is used and a captain-definition file is entered in the text box, when the deploy button is pressed, the captain-definition file is not retained.

Retaining it and re-displaying it whenever a user returns to the deployment page can be useful: it facilitates re-deployment (e.g. when environment variables are updated), or when a mistake (e.g. a typo) is made in the captain-definition file.

Describe the solution you'd like When "deploy" is pressed, the inputted captain-definition file should be saved and re-displayed when the page is viewed subsequently.

Describe alternatives you've considered Of course, captain-definition files are generally short, and one can simply type them up again, but it would save time if they were automatically retained.

Additional context image

bevinhex commented 5 years ago

I'd also love to be able to export definition file for all running projects, after all deploying with docker does not give me anything, I wish I had created project and source code for all deployments

ItsMeBrianD commented 5 years ago

As a note; using GitHub as a deployment method will solve this issue natively, and will also let you version control things, get automatic deployments based on a branch, along with many other pretty standard CD features. I would recommend trying that out.

If you are concerned about sharing code, GitHub now (I believe this is fairly new) lets you have unlimited private repos with 3 contributors; it is also considered best practice to create a read-only account with access to the repo for Caprover, to prevent any tampering in case of a breach. An SSH key is also a good method, because it will prevent a password being exposed, and can be easily deactivated.

Docs: https://caprover.com/docs/deployment-methods.html#automatic-deploy-using-github-bitbucket-and-etc

dg-otrs commented 4 years ago

I can recommend @0c370t comment. I switched also and its more than awesome