caprover / caprover-website

CapRover Website and Docs
http://www.CapRover.com
16 stars 107 forks source link

ssh keygen command that is compatible with caprover #127

Closed vinaydate closed 1 year ago

vinaydate commented 1 year ago

The reference issue is this.

I have personally verified the generated key with suggested command

githubsaturn commented 1 year ago

Thanks, Vinay! But I think the problem with the previous command in the doc was the "format", not the key type which I've already fixed here: https://github.com/caprover/caprover-website/commit/022abbe17e544e9b507760e1e7bbf372f7f1f279

Would you please be able to test the current command in the doc and confirm whether it works or not for you?

ssh-keygen -m PEM -t ed25519 -C "yourname@example.com" -f ./deploykey -q -N ""

Github considers the rsa keys legacy and obsolete: https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent

image

vinaydate commented 1 year ago

Hi

Appreciate your quick review.

I had tried

ssh-keygen -m PEM -t ed25519 -C @.***" -f ./deploykey -q -N ""

this command and it did not work in my case. But today, when I thought to give it a try. (Due consideration being, you must have tried and tested this). And it worked. Don't what was missing earlier. Anyways, thanks to your whole team for Caprover.

So, I will close the pull request


From: Kasra Bigdeli @.> Sent: 29 July 2023 08:29 To: caprover/caprover-website @.> Cc: विनय @.>; Author @.> Subject: Re: [caprover/caprover-website] ssh keygen command that is compatible with caprover (PR #127)

Thanks, Vinay! But I think the problem with the previous command in the doc was the "format", not the key type which I've already fixed here: 022abbehttps://github.com/caprover/caprover-website/commit/022abbe17e544e9b507760e1e7bbf372f7f1f279

Would you please be able to test the current command in the doc and confirm whether it works or not for you?

ssh-keygen -m PEM -t ed25519 -C @.***" -f ./deploykey -q -N ""

Github considers the rsa keys legacy and obsolete: https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent

[image]https://user-images.githubusercontent.com/10582082/256960226-50ef6de9-7018-4be8-bac8-8775988cfb30.png

— Reply to this email directly, view it on GitHubhttps://github.com/caprover/caprover-website/pull/127#issuecomment-1656530670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABQSVRG4IX2FIFI6UNLMDCLXSR4AJANCNFSM6AAAAAA23KTUMI. You are receiving this because you authored the thread.Message ID: @.***>

githubsaturn commented 1 year ago

Thanks! Glad to hear that the current command works well.

Feel free to reopen of things change.

yangcheng commented 3 weeks ago

in my case I have to create a new key without passphrase. in UI I did not find a place to enter passphrase